[webkit-reviews] review granted: [Bug 11396]
KRenderingFill-/StrokePainter needs to die : [Attachment
11190] Initial patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Tue Oct 24 10:14:05 PDT 2006
Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 11396: KRenderingFill-/StrokePainter needs to die
http://bugs.webkit.org/show_bug.cgi?id=11396
Attachment 11190: Initial patch
http://bugs.webkit.org/attachment.cgi?id=11190&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
#import "SVGRenderStyle.h"
#import "SVGStyledElement.h"
+#import "KCanvasRenderingStyle.h"
Please make these #imports alphabetical
+void applyStrokeStyleToContext(CGContextRef context, RenderStyle* style, const
RenderObject* object)
+FloatRect strokeBoundingBox(const Path& path, RenderStyle* style, const
RenderObject* object)
Can these take a const RenderStyle*?
#include "SVGPaint.h"
+#include "GraphicsTypes.h"
Alphabetical, please.
SVN will not be happy if you leave the tabs in
WebCore/ksvg2/misc/KCanvasRenderingStyle.cpp :-)
r=me
More information about the webkit-reviews
mailing list