[webkit-reviews] review denied: [Bug 11336] HashTable.h not zeroing pointers in constructuor : [Attachment 11127] Missed the second constructor

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Oct 21 18:48:53 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11336: HashTable.h not zeroing pointers in constructuor
http://bugs.webkit.org/show_bug.cgi?id=11336

Attachment 11127: Missed the second constructor 
http://bugs.webkit.org/attachment.cgi?id=11127&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This patch won't compile (missing colon in the second constructor).

And I'm not convinced the change is helpful. I understand that this confused
you once while debugging, but I'd prefer to just leave this as-is unless you
present a more compelling argument to change it.



More information about the webkit-reviews mailing list