[webkit-reviews] review requested: [Bug 10893] InsertRule can not
handle @import statements : [Attachment 11174] Improved patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Sat Oct 21 06:25:45 PDT 2006
Rob Buis <rwlbuis at gmail.com> has asked for review:
Bug 10893: InsertRule can not handle @import statements
http://bugs.webkit.org/show_bug.cgi?id=10893
Attachment 11174: Improved patch
http://bugs.webkit.org/attachment.cgi?id=11174&action=edit
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch should eliminate the assertion failure problems. It is actually
quite tricky to get this right it seems, but I didn't find any better solution
than this. I don't think there is an equivalent test that would allow us to get
rid of the extra bool in CSSStyleSheet, but I'd love to be proven wrong there.
Also note that the testcase is slightly cleaned up.
Cheers,
Rob.
More information about the webkit-reviews
mailing list