[webkit-reviews] review denied: [Bug 11108] Replace usage of split
by proper parsers : [Attachment 10944] Slightly cleaned up patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Fri Oct 20 13:47:06 PDT 2006
mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11108: Replace usage of split by proper parsers
http://bugs.webkit.org/show_bug.cgi?id=11108
Attachment 10944: Slightly cleaned up patch
http://bugs.webkit.org/attachment.cgi?id=10944&action=edit
------- Additional Comments from mitz at webkit.org
Additional observations:
In SVGColor::setRGBColor(), normal == 3 - percentages, so you don't need two
variables.
Brace should be indented:
+ static inline bool skipOptionalSpaces(const UChar*& ptr) // true means
"found space"
+{
Brace should be on the switch line:
+ switch (type)
+ {
More information about the webkit-reviews
mailing list