[webkit-reviews] review denied: [Bug 11367] Inline Breakpoint Editor Improvements: Act III : [Attachment 11162] See bug description

[bugzilla-request-daemon at macosforge.org]

Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 11367: Inline Breakpoint Editor Improvements: Act III
http://bugs.webkit.org/show_bug.cgi?id=11367

Attachment 11162: See bug description
http://bugs.webkit.org/attachment.cgi?id=11162&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Looks good.

Some comments:

Make the bullets in the ChangeLog asterisks.

Remove the white background and border on the .hitCounter.

Make sure you didn't break the console history now that we can log msgs without
expressions. IIRC the history relied on childNode indices.

+    while(!node.hasStyleClass(className))
+    {

Our style puts the { on the same line as while.

+	 if(node == document) return null;

Our style puts the "return null;" on the next line. Also a space after the if.

The same same firstParentWithClass code in viewer.html.

new Function("toggleBreakpointEditorOnLine(parseInt(event.target.title));")

This can be written as:

function () { toggleBreakpointEditorOnLine(parseInt(event.target.title)); }

+    if(breakpoint && breakpoint.enabled) {
+		 if(shouldBreak)
+		 if(breakpoint.value != "break")
+		 if(consoleWindow)
+	 if(editor)
+	 if(counter)

Add a space after the if.