[webkit-reviews] review denied: [Bug 11217] Cleanup svg coding style : [Attachment 11114] First attempt

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Oct 20 00:18:30 PDT 2006


mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11217: Cleanup svg coding style
http://bugs.webkit.org/show_bug.cgi?id=11217

Attachment 11114: First attempt
http://bugs.webkit.org/attachment.cgi?id=11114&action=edit

------- Additional Comments from mitz at webkit.org
Don't need "!= 0" here:
+    for (Node* n = firstChild(); n != 0; n = n->nextSibling()) {

Don't need the "angle" and "attr" parameter names: 
+	 void setOrientToAngle(SVGAngle* angle);

	 virtual void attributeChanged(Attribute* attr, bool preserveDecls);



More information about the webkit-reviews mailing list