[webkit-reviews] review requested: [Bug 11323] Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref : [Attachment 11128] patch

[bugzilla-request-daemon at macosforge.org]

Graham Dennis <Graham.Dennis at gmail.com> has asked Justin Garcia
<justin.garcia at apple.com> for review:
Bug 11323: Link dragging behaviour does not obey WebKitEditableLinkBehavior
WebPref
http://bugs.webkit.org/show_bug.cgi?id=11323

Attachment 11128: patch
http://bugs.webkit.org/attachment.cgi?id=11128&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
This patch modifies the UI delegate so that it can be tested without writing a
wrapper application.
Other changes include clearing the *OnMouseDown variables in HTMLAnchorElement
(see bug 10338) on mouseenter and not mouseout. This is because the values of
these variables are needed for drag operations but these happen after mouseout
events. It shouldn't be necessary to clear these variables at all because they
are only accessed on a mouse click or mouse drag event, both of which happen
after a mousedown event. But I figure it's best to clear them for safety
anyway.

I'm not sure that it is possible to test this automatically, so I've just
modified the description for the contenteditable-link.html manual test to
describe these changes.

I added the WebElementLinkIsLiveKey to the WebElementDictionary so that
WebHTMLView can determine whether or not a link is 'live', and so if it is
draggable.