[webkit-reviews] review denied: [Bug 11217] Cleanup svg coding
style : [Attachment 11089] First attempt
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Sat Oct 14 14:32:27 PDT 2006
mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11217: Cleanup svg coding style
http://bugs.webkit.org/show_bug.cgi?id=11217
Attachment 11089: First attempt
http://bugs.webkit.org/attachment.cgi?id=11089&action=edit
------- Additional Comments from mitz at webkit.org
My only comments are about lines that the patch doesn't touch:
The opening brace should go on the same line as the case:
case SVG_LENGTHTYPE_EXS:
{
This needs spaces after the semicolons:
for (unsigned long i = 0;i < list->numberOfItems();i++) {
The way this is split into lines doesn't make sense. I think two lines with 4
parameters in each will suffice, but otherwise, it should be 2 parameters on
each line:
+ SVGMatrix* getCTM(float logicX, float logicY,
float logicWidth, float logicHeight,
float physX, float physY, float physWidth,
float physHeight);
More information about the webkit-reviews
mailing list