[webkit-reviews] review denied: [Bug 11217] Cleanup svg coding
style : [Attachment 11073] First attempt
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Fri Oct 13 12:53:17 PDT 2006
mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11217: Cleanup svg coding style
http://bugs.webkit.org/show_bug.cgi?id=11217
Attachment 11073: First attempt
http://bugs.webkit.org/attachment.cgi?id=11073&action=edit
------- Additional Comments from mitz at webkit.org
Redundant parameter names (some of these show up multiple times):
- virtual void buildGradient(KRenderingPaintServerGradient *grad) const
= 0;
+ virtual void buildGradient(KRenderingPaintServerGradient* grad) const
= 0;
- const SVGStyledElement *pushAttributeContext(const SVGStyledElement
*context);
+ const SVGStyledElement* pushAttributeContext(const SVGStyledElement*
context);
- virtual void buildGradient(KRenderingPaintServerGradient *grad) const;
+ virtual void buildGradient(KRenderingPaintServerGradient* grad) const;
Don't need the "!= 0" here:
+ for (Node* n = target->firstChild(); n != 0; n = n->nextSibling()) {
Don't need the space before the > here (some of these show up multiple times):
SVGStyledElement* e = static_cast<SVGStyledElement* >(elem);
SVGStyledElement* styled = (current ? static_cast<SVGStyledElement*
>(current->element()) : 0);
m_paintServer->setListener(const_cast<SVGPatternElement* >(this));
- KRenderingPaintServerRadialGradient *grad =
static_cast<KRenderingPaintServerRadialGradient *>(_grad);
+ KRenderingPaintServerRadialGradient* grad =
static_cast<KRenderingPaintServerRadialGradient* >(_grad);
- KRenderingPaintServerGradient *gradient =
static_cast<KRenderingPaintServerGradient *>(pserver);
+ KRenderingPaintServerGradient* gradient =
static_cast<KRenderingPaintServerGradient* >(pserver);
+ KRenderingPaintServerRadialGradient* radial =
static_cast<KRenderingPaintServerRadialGradient* >(pserver);
More information about the webkit-reviews
mailing list