[webkit-reviews] review denied: [Bug 11217] Cleanup svg coding style : [Attachment 11052] First attempt

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Oct 13 00:56:33 PDT 2006


mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11217: Cleanup svg coding style
http://bugs.webkit.org/show_bug.cgi?id=11217

Attachment 11052: First attempt
http://bugs.webkit.org/attachment.cgi?id=11052&action=edit

------- Additional Comments from mitz at webkit.org
Unnecessary parameter names in
+	 SVGDocument(DOMImplementation* i, FrameView* view);

These should be two lines each:
+    if (SVGLangSpace::parseMappedAttribute(attr)) return;
+    if (SVGExternalResourcesRequired::parseMappedAttribute(attr)) return;
+    if (SVGFitToViewBox::parseMappedAttribute(attr)) return;

I also discussed with Rob the commented-out code in SVGSVGElement.cpp. Those
comments should be deleted and replaced with FIXMEs, preferably referring to
bugs about the missing functionality.



More information about the webkit-reviews mailing list