[webkit-reviews] review denied: [Bug 4166] Function object does not support caller property : [Attachment 11056] Patch

[bugzilla-request-daemon at macosforge.org]

Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 4166: Function object does not support caller property
http://bugs.webkit.org/show_bug.cgi?id=4166

Attachment 11056: Patch
http://bugs.webkit.org/attachment.cgi?id=11056&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
A few minor quibbles, then I think this is ready to land:

- Our style guidelines call for "* " and "& " rather than " *" and " &".

- Your test case is very confusting. If it started failing, it would take me a
while to figure out why. Two suggestions: (1) choose 'inner' and 'outer' or
'parent' and 'child' -- don't use both; (2) Make your shouldBe explain what
they test more clearly. For example, shouldBe('innerHasCaller', 'false'),
shouldBe('innerHasCallerWhenCalledFromGlobalCode', 'false'),
shouldBe('innerHasCallerWhenCalledFromFunction'), 'true').