[webkit-reviews] review requested: [Bug 11262] Fix gdk build, make curl networking depndent on USE(CURL) : [Attachment 11044] Fix gdk build etc.

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Oct 12 04:01:10 PDT 2006


Krzysztof Kowalczyk <kkowalczyk at gmail.com> has asked  for review:
Bug 11262: Fix gdk build, make curl networking depndent on USE(CURL)
http://bugs.webkit.org/show_bug.cgi?id=11262

Attachment 11044: Fix gdk build etc.
http://bugs.webkit.org/attachment.cgi?id=11044&action=edit

------- Additional Comments from Krzysztof Kowalczyk <kkowalczyk at gmail.com>
This patch:
* makes CURL networking dependent on USE(CURL) instead of PLATFORM(GDK), so
that other platforms can also use CURL, if they wish.
* fixes GDK build by defining FrameGdkClient() constructor as non-virtual. Pure
virtual classes require non-pure destructor. Who knew.
* silences compiler warning about unused variable in SharedTimerLinux.cpp



More information about the webkit-reviews mailing list