[webkit-reviews] review denied: [Bug 11257] Remove mac platform
dependance from Loader::ReceivedResponse() and
CachedImage::createImage() : [Attachment 11038] Updated patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Thu Oct 12 02:41:38 PDT 2006
Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 11257: Remove mac platform dependance from Loader::ReceivedResponse() and
CachedImage::createImage()
http://bugs.webkit.org/show_bug.cgi?id=11257
Attachment 11038: Updated patch
http://bugs.webkit.org/attachment.cgi?id=11038&action=edit
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks generally ok, but here's some things I'm sure about:
-#if __APPLE__
m_image = new Image(this, ResponseMIMEType(m_response) ==
"application/pdf");
-#else
- m_image = new Image(this, false);
-#endif
I don't think any platform but Mac supports PDF images yet, so I'm not sure
this is right. but maybe Image will fail gracefully.
As a matter of style, we don't usually use this kind of initialization for
non-class types, just = would be better.
+ NSURLResponse* response(platResponse);
r- for now to consider these comments.
More information about the webkit-reviews
mailing list