[webkit-reviews] review denied: [Bug 11217] Cleanup svg coding
style : [Attachment 11035] Improved patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Wed Oct 11 13:53:14 PDT 2006
mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11217: Cleanup svg coding style
http://bugs.webkit.org/show_bug.cgi?id=11217
Attachment 11035: Improved patch
http://bugs.webkit.org/attachment.cgi?id=11035&action=edit
------- Additional Comments from mitz at webkit.org
There are several declarations (repeating in several headers) where you could
drop the parameter names:
+ virtual void parseMappedAttribute(MappedAttribute* attr);
+ virtual RenderObject* createRenderer(RenderArena* arena, RenderStyle*
style);
+ bool childShouldCreateRenderer(Node* child) const;
+ virtual void updateLocalTransform(SVGTransformList* localTransforms);
The second line here should be indented:
+SVGTSpanElement::SVGTSpanElement(const QualifiedName& tagName, Document* doc)
: SVGTextPositioningElement(tagName, doc)
More information about the webkit-reviews
mailing list