[webkit-reviews] review denied: [Bug 11251] fill methods in <canvas> throw JS exceptions for 0 size elements : [Attachment 11029] patch

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11251: fill methods in <canvas> throw JS exceptions for 0 size elements
http://bugs.webkit.org/show_bug.cgi?id=11251

Attachment 11029: patch
http://bugs.webkit.org/attachment.cgi?id=11029&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This patch breaks handling of NaN. We need to add test cases that pass
non-numeric values (which turn into NaN) and then fix the code to say things
like:

    if (!(r >= 0))

rather than

    if (r < 0)

because expressions with NaN always yield false.