[webkit-reviews] review requested: [Bug 10216] PDF created by printing should have live hyperlinks : [Attachment 11030] Cleaned up and slightly different patch.

[bugzilla-request-daemon at macosforge.org]

Beth Dakin <bdakin at apple.com> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 10216: PDF created by printing should have live hyperlinks
http://bugs.webkit.org/show_bug.cgi?id=10216

Attachment 11030: Cleaned up and slightly different patch.
http://bugs.webkit.org/attachment.cgi?id=11030&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is a cleaned up patch. I have posted it for review again, though, because
it is also slightly different. Hyatt and I were talking on IRC, and we realized
that a CSS property is not necessary after all; all of the information we need
if available right in RenderObject. So I added hasOutlineAnnotation() and
hasOutline() to RenderObject.h instead of having th annotation be a style.
Otherwise, the patch is pretty much the same as Ken's last patch. 

Ken, it would be really helpful if you could either tell me how you have been
testing this or if you could roll my patch into your tree and test it yourself.
I am fairly positive that this patch will have identical behavior to your last
one, but I would like to check before landing it.