[webkit-reviews] review requested: [Bug 11226] linux/gdk build fixes; fix memleaks; gdk improvements : [Attachment 10991] linux/gdk build fixes; minor gdk improvements

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Oct 9 06:02:12 PDT 2006


Krzysztof Kowalczyk <kkowalczyk at gmail.com> has asked  for review:
Bug 11226: linux/gdk build fixes; fix memleaks; gdk improvements
http://bugs.webkit.org/show_bug.cgi?id=11226

Attachment 10991: linux/gdk build fixes; minor gdk improvements
http://bugs.webkit.org/attachment.cgi?id=10991&action=edit

------- Additional Comments from Krzysztof Kowalczyk <kkowalczyk at gmail.com>
Fix gdk build by adding missing PlatformScrollbar functions.

Improve gdk by:
* change compiler options to not use rtti and exceptions, which is the same
thing that mac build is doing and results in significant savings in the size of
stripped executable
* set warning to default (from off) and make sure debug info is generated.
* mark ~FrameGdk() as virtual, as it should be
* define SOURCE_ROOT in make-generated-sources.sh since it's used by one of the
code generation scripts and without it make-generated-sources.sh fail for gdk
build
* cleanup GdkLauncher\main.cpp formatting and add -exit-after-loading
command-line option which causes the app to exit after fully loading and
rendering a page. It's very useful for e.g. running automated memory leaks and
profiling tests with valgrind
* fix 2 memory leaks (ImageCairo.cpp and FrameGkd.cpp) found by running
valgrind



More information about the webkit-reviews mailing list