[webkit-reviews] review denied: [Bug 11160] Double Click to Select Words does not work on Windows : [Attachment 10937] patch for review

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11160: Double Click to Select Words does not work on Windows
http://bugs.webkit.org/show_bug.cgi?id=11160

Attachment 10937: patch for review
http://bugs.webkit.org/attachment.cgi?id=10937&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great. A few nits:

We don't use relative paths in includes. So this:

+#include "icu/BreakIterator.h"

should just be:

#include "BreakIterator.h"

And we deal with the paths in the project setup.

The copyright in BreakIterator.h/cpp only needs to mention Apple and 2006. Use
of ICU for word breaking came in 2006, so there's no need to copy the other
copyrights from StringImpl.h since they didn't cover the break iterator. No way
you could have known that, but should fix it.

+namespace WebCore {
+
+typedef void UBreakIterator;

UBreakIterator should be declared outside the WebCore namespace to match how
it's defined in ICU. This declaration instead adds a new UBreakIterator inside
the WebCore namespace.