[webkit-reviews] review cancelled: [Bug 10380] tspans don't support styles : [Attachment 10972] Final (hopefully) patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Oct 8 01:40:26 PDT 2006


Oliver Hunt <ojh16 at student.canterbury.ac.nz> has cancelled Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 10380: tspans don't support styles
http://bugs.webkit.org/show_bug.cgi?id=10380

Attachment 10972: Final (hopefully) patch
http://bugs.webkit.org/attachment.cgi?id=10972&action=edit

------- Additional Comments from Oliver Hunt <ojh16 at student.canterbury.ac.nz>
the remaining issue would seem to be the use of a m_isSVGFlow flag instead of
virtual methods for layout.  I'm hesitant to use virtual methods in the middle
of the layout code as that introduces new virtual calls to the layout code for
non-svg files as well.



More information about the webkit-reviews mailing list