[webkit-reviews] review requested: [Bug 11184] fixing failed two failed mozilla Date reg tests on windows : [Attachment 10949] revised patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Oct 6 11:05:36 PDT 2006


Ian Eng <engian at gmail.com> has asked  for review:
Bug 11184: fixing failed two failed mozilla Date reg tests on windows
http://bugs.webkit.org/show_bug.cgi?id=11184

Attachment 10949: revised patch
http://bugs.webkit.org/attachment.cgi?id=10949&action=edit

------- Additional Comments from Ian Eng <engian at gmail.com>
Darin, thanks for your review. I took your suggestion and changed the first
parameter of dateToMseconds to "const tm&". I did grep the function name in *.h
and *.cpp under WebKit, all references found are in date_object.cpp. And these
calls are fixed. I hope no other references are missed.

As you mentioned that renaming of several other functions has nothing to do
with this patch. I am not going to touch that part.



More information about the webkit-reviews mailing list