[webkit-reviews] review denied: [Bug 11184] fixing failed two failed mozilla Date reg tests on windows : [Attachment 10943] get correct GMT offset when DST is on

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11184: fixing failed two failed mozilla Date reg tests on windows
http://bugs.webkit.org/show_bug.cgi?id=11184

Attachment 10943: get correct GMT offset when DST is on
http://bugs.webkit.org/attachment.cgi?id=10943&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
We should not be doing a const_cast like this. If we need to make a change like
this, then dateToMseconds should be changed to take a const tm*.

(And, in passing, "dateToMseconds" is a strangely-capitalized name; we should
fix that too. And it's very strange that isDST takes a const double& instead of
a double. But neither of those has anything to do with this patch.)