[webkit-reviews] review denied: [Bug 11160] Double Click to Select Words does not work on Windows : [Attachment 10919] straw man patch

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11160: Double Click to Select Words does not work on Windows
http://bugs.webkit.org/show_bug.cgi?id=11160

Attachment 10919: straw man patch
http://bugs.webkit.org/attachment.cgi?id=10919&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine.

But we don't want to add a new copy of the code from TextUtilities.mm. Instead,
we need to delete currentTextBreakLocaleID, and the two sentence functions from
TextUtilities.mm, and we need to update the project file on Macintosh as well
as on Windows to include TextUtilities.cpp, with proper ifdefs. At some point
we might even share the word boundary code, but for now we should probbably
leave the Objective-C version on Macintosh in case it does something better
than the ICU version.

review- because we need a patch that doesn't create two copies of the code.