[webkit-reviews] review granted: [Bug 11054] REGRESSION: Traditional Chinese encoding in login authentication : [Attachment 10915] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Oct 5 07:42:40 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11054: REGRESSION: Traditional Chinese encoding in login authentication
http://bugs.webkit.org/show_bug.cgi?id=11054

Attachment 10915: proposed fix
http://bugs.webkit.org/attachment.cgi?id=10915&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I would have done it slightly differently (for example, I don't normally use
!strcmp for string equality; I like strcmp == 0 because it has an "==" in it),
but this looks good.

r=me



More information about the webkit-reviews mailing list