[webkit-reviews] review denied: [Bug 10216] PDF created by printing should have live hyperlinks : [Attachment 10913] This patch will create URL links in PDF documents.

[bugzilla-request-daemon at macosforge.org]

Beth Dakin <bdakin at apple.com> has denied Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 10216: PDF created by printing should have live hyperlinks
http://bugs.webkit.org/show_bug.cgi?id=10216

Attachment 10913: This patch will create URL links in PDF documents.
http://bugs.webkit.org/attachment.cgi?id=10913&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
The CSSPrimitveValue class does not have a constructor tat accepts a boolean
value, so I am not sure exactly what the constructor you added to
CSSComputedStyleDeclaration will do, but it will probably do something funny.
In the parser, you only let -webkit-outline-annotation have one of two values:
CSS_VAL__WEBKIT_LINK, or CSS_VAL_NONE. So you probably want something like:

    case CSS_PROP__WEBKIT_OUTLINE_ANNOTATION:
	if (style->outlineAnnotation()) 
+	     return new CSSPrimitiveValue(CSS_VAL__WEBKIT_LINK);
	return new CSSPrimitiveValue(CSS_VAL_NONE);
+	 break;