[webkit-reviews] review requested: [Bug 10216] PDF created by printing should have live hyperlinks : [Attachment 10903] This patch will create URL links in PDF documents.

[bugzilla-request-daemon at macosforge.org]

Ken Kraisler <kraisler at apple.com> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 10216: PDF created by printing should have live hyperlinks
http://bugs.webkit.org/show_bug.cgi?id=10216

Attachment 10903: This patch will create URL links in PDF documents.
http://bugs.webkit.org/attachment.cgi?id=10903&action=edit

------- Additional Comments from Ken Kraisler <kraisler at apple.com>
1. I resolved conficts in the ChangeLog.
2. I added spaces after the ifs.
3. I have 3 functions in RenderObject.	They are needed because of the
complexities of RenderBlock.  Without my patch to RenderBlock, my sample
ancestors and fruit documents (see attachments) will not work.
These 3 functions support the various cases needed between RenderBlock and
RenderFlow.
4. As for not needing to touch RenderBlock, please debug through it using my
sample documents.
5. Using the CSS property we created there is not necessarily an outline style
on the RenderObject and so paintOutlines and paintOutline will not necessarily
be called.  Please debug through it yourself to validate.  We are not forcing a

RenderStyle on the link RenderObject.  If we force something like DOTTED, then
yes we'd hit that code, however putting this style on that object was deemed
bogus. We're using outline as a sample of how to do it, not necessarily
actually generating an outline.
6. I'm not sure of where or what this is: The new CSS property needs computed
style implemented.
7. I did the following: The boolean in
RenderStyle that you added to CSS3NonInheritedData needs to be initialized and
also added to the copy constructor and assignment operator.