[webkit-reviews] review requested: [Bug 10989] Provide a way for embedders to implement BrowserExtensionWin : [Attachment 10873] Patch to forward to the UIDelegate

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Oct 2 14:19:55 PDT 2006


Marvin Decker <marv.decker at gmail.com> has asked  for review:
Bug 10989: Provide a way for embedders to implement BrowserExtensionWin
http://bugs.webkit.org/show_bug.cgi?id=10989

Attachment 10873: Patch to forward to the UIDelegate
http://bugs.webkit.org/attachment.cgi?id=10873&action=edit

------- Additional Comments from Marvin Decker <marv.decker at gmail.com>
This patch is based on DarinA and Maciej's help.

This adds a new file for BrowserExtensionWin where the TemporaryLinkStubs
functions have been moved, and hooks up the createNewWindow calls (the rest
remain the same stubs as in TemporaryLinkStubs). They are forwarded to the
FrameWin, which then forwards them to the WebFrame. The WebFrame then calls the
UIDelegate (if any) provided by the embedder.

The IDL declaration of the retval of IWebUIDelegate::createWebViewWithRequest
seemed to be incorrect, so this also fixes that.



More information about the webkit-reviews mailing list