[webkit-reviews] review granted: [Bug 11108] preserveAspectRatio crashes when empty : [Attachment 10854] First attempt

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 11108: preserveAspectRatio crashes when empty
http://bugzilla.webkit.org/show_bug.cgi?id=11108

Attachment 10854: First attempt
http://bugzilla.webkit.org/attachment.cgi?id=10854&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks fine.

You should probably search for all other uses of DeprecatedString::split. 
There may be other crashing cases.  Do we adequately protect against having
only 1 or 2 or 3 params?

Using DeprecatedStringList::split is really bad practice, since it copies the
string for parsing, instead of just walking it.  But at least this fixes the
crash for now.