[webkit-reviews] review granted: [Bug 10383] KRenderingDeviceContextQuartz must DIE : [Attachment 11681] Initial complete patch for Cg & Qt

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Nov 30 10:35:19 PST 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10383: KRenderingDeviceContextQuartz must DIE

Attachment 11681: Initial complete patch for Cg & Qt

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks fine.

CgSupport should really be CGSupport

There are a couple old spacing issues, on lines which were touched (but the
spacing not corrected).

I really really really really think that Image::createGraphicsContext() needs
to be added ASAP.  That's the *correct* way to do masking and patterns etc.  
The current solution is a bad hack.  I would encourage you to add
Image::createGraphicsContext either before this patch lands or right after.

This is a huge change for someone so out-of-touch with the project to approve
alone.	I've reviewed the code for sanity, but I think you should have an Apple
reviewer rubber stamp that this large of a change is OK to land given whatever
the current project state is.

(You and I had some additional discussion over IRC, and you said you had an
updated patch.	I'm going to r+ this one, but you should land the updated

More information about the webkit-reviews mailing list