[webkit-reviews] review requested: [Bug 11678] [S60] tabbing
navigation skips over text content : [Attachment 11642] apply
corrections based on Zalan's comments
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Mon Nov 27 08:30:45 PST 2006
Shaun Keller <shaun.keller at nokia.com> has asked Zalan Bujtas
<zbujtas at gmail.com> for review:
Bug 11678: [S60] tabbing navigation skips over text content
http://bugs.webkit.org/show_bug.cgi?id=11678
Attachment 11642: apply corrections based on Zalan's comments
http://bugs.webkit.org/attachment.cgi?id=11642&action=edit
------- Additional Comments from Shaun Keller <shaun.keller at nokia.com>
Thanks for catching the nodeIndex errors. The delta is: removed the creation
of shadowing variables; added a test for return nodeIndex value of -1 which now
skips over changing the cursor position based on a found node; corrected
comments and indenting. I rebuilt, tested and reviewed the changes with
Sriram.
More information about the webkit-reviews
mailing list