[webkit-reviews] review denied: [Bug 6484] font-weight does not properly support graded font-weight : [Attachment 11629] Adds numerical and basic keyword support for graded font-weights

[bugzilla-request-daemon at macosforge.org]

Oliver Hunt <ojh16 at student.canterbury.ac.nz> has denied Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 6484: font-weight does not properly support graded font-weight
http://bugs.webkit.org/show_bug.cgi?id=6484

Attachment 11629: Adds numerical and basic keyword support for graded
font-weights
http://bugs.webkit.org/attachment.cgi?id=11629&action=edit

------- Additional Comments from Oliver Hunt <ojh16 at student.canterbury.ac.nz>
I don't like the VAL_BOLDER handling -- possibly talk to hyatt.

Reorder the switch cases, so that they're in order

Why does FontDescription: :m_weight become signed?  You lose a bit of precision
for very little gain.  Why do you use -1 to indicate badness -- why not 0?

Wha?
+
+    // Discourage Extra Black weight fonts
+    if (candidateWeight > 10)
+	 return NO;

Is there a reason for 
-#define STANDARD_WEIGHT 5
-#define MIN_BOLD_WEIGHT 9
-#define STANDARD_BOLD_WEIGHT 10
+#define STANDARD_WEIGHT 4
+#define MIN_BOLD_WEIGHT 6
+#define STANDARD_BOLD_WEIGHT 8

Could this change rendering of many pages?

Have you run the layout tests? 
That'll be an absolute necessity for this patch.