[webkit-reviews] review requested: [Bug 6484] font-weight does not properly support graded font-weight : [Attachment 11629] Adds numerical and basic keyword support for graded font-weights

[bugzilla-request-daemon at macosforge.org]

Alex Taylor <darwin at techvisual.co.nz> has asked  for review:
Bug 6484: font-weight does not properly support graded font-weight
http://bugs.webkit.org/show_bug.cgi?id=6484

Attachment 11629: Adds numerical and basic keyword support for graded
font-weights
http://bugs.webkit.org/attachment.cgi?id=11629&action=edit

------- Additional Comments from Alex Taylor <darwin at techvisual.co.nz>
This patch adds support for font-weights 100 through 900 to map to the weight
in font-faces. Keyword support (bolder, lighter) is only basic and only does
numerical adjustments whereas the spec suggests that lighter should map to a
font-variant lighter and bolder should map to a font-variant bolder.
However it also says that behavious in is not guaranteed and the only guarantee
is that "bolder" will result in a face that is "not lighter than the current"
and vice-versa for "lighter".

LayoutTests/css2.1/t1506-c525-font-wt-00-b.html is already a testcase for this
behaviour, the only better behaviour would be to have it render with a
font-family with more weight-variants (like Helvetica Neue) and it would then
the fix would be apparent in the pixel-test case.