[webkit-reviews] review denied: [Bug 11681] Resetting a multiple-select control selects first item rather than none : [Attachment 11616] Checks for multiple-select before setting option on reset

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Nov 22 23:16:57 PST 2006


mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11681: Resetting a multiple-select control selects first item rather than
none
http://bugs.webkit.org/show_bug.cgi?id=11681

Attachment 11616: Checks for multiple-select before setting option on reset
http://bugs.webkit.org/attachment.cgi?id=11616&action=edit

------- Additional Comments from mitz at webkit.org
The code change looks good, but shouldn't the same logic apply also to
single-choice listboxes (e.g. <select size="5">)? It would be nice to fix this
case as well.

+	 WARNING: NO TEST CASES ADDED OR CHANGED

You should indeed add a layout test.

r- due to the missing test.



More information about the webkit-reviews mailing list