[webkit-reviews] review requested: [Bug 11519] REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html : [Attachment 11588] Improved patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Nov 20 12:51:45 PST 2006


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 11519: REGRESSION: Disabled file upload control doesn't have disabled
appearance, failing fast/forms/file-input-disabled.html
http://bugs.webkit.org/show_bug.cgi?id=11519

Attachment 11588: Improved patch
http://bugs.webkit.org/attachment.cgi?id=11588&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
With hindsight, dealing with checked property for file input makes no sense at
all. The file input also does not seem to react to setting active/select().
Finally it is not needed to set the focus property, I tested it and it seems to
work on ToT. So really I think I was trying to do too much and just dealing
with disabled is all that is needed.
Cheers,

Rob.



More information about the webkit-reviews mailing list