[webkit-reviews] review requested: [Bug 11633] Implement XMLDocument properties xmlEncoding, xmlVersion, xmlStandalone : [Attachment 11576] proposed patch

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 11633: Implement XMLDocument properties xmlEncoding, xmlVersion,
xmlStandalone
http://bugs.webkit.org/show_bug.cgi?id=11633

Attachment 11576: proposed patch
http://bugs.webkit.org/attachment.cgi?id=11576&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The patch doesn't include changes to dom/xhtml/level3/core results -
svn-create-patch chokes on these, probably because of the UTF-16 test that I
re-added.

One thing I don't like in this patch is that I had to add wk_ucfirst to both JS
and ObjC generators - I couldn't make it work when it was in CodeGenerator.pm
(calling it as $codeGenerator->wk_ucfirst resulted in something weird like
"CodeGenerator->HASH(...) being printed to the output). Leaving this to someone
more proficient with Perl for future cleanup.