[webkit-reviews] review cancelled: [Bug 11625] Investigate possibility to share code between HTMLStyleElement and SVGStyleElement : [Attachment 11547] First attempt

[bugzilla-request-daemon at macosforge.org]

Rob Buis <rwlbuis at gmail.com> has cancelled Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 11625: Investigate possibility to share code between HTMLStyleElement and
SVGStyleElement
http://bugs.webkit.org/show_bug.cgi?id=11625

Attachment 11547: First attempt
http://bugs.webkit.org/attachment.cgi?id=11547&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch should address Darin's issues with the previous patch. Note the
AtomicString changes in particular. I think something like tryGetAttribute(NS)
should either be used everywhere or not at all, ie. it makes little sense IMHO
to limit it to svg use only. Seeing that knowing up front the default value is
not so common, I think we do not need tryGetAttribute(NS).
Cheers,

Rob.