[webkit-reviews] review denied: [Bug 11587] -webkit-border-bottom-right-radius is drawn at the wrong Y value : [Attachment 11502] First look patch (no tests yet)

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Nov 18 00:53:13 PST 2006

mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11587: -webkit-border-bottom-right-radius is drawn at the wrong Y value

Attachment 11502: First look patch (no tests yet)

------- Additional Comments from mitz at webkit.org
Looks good! Your test should a box whose bottom-left, bottom-right and
top-right are distinct. In order to test the second change, the bottom border
and the right border should not match (e.g. have different color). You can use
LayoutTests/fast/borders/borderRadiusSolid01.html as a starting point. After
you make the test, you need to generate expected results. The run-webkit-tests
script does that by default for tests that don't have expected results, so you
just need to run it on your test. Make sure to use the --pixel option in order
to have pixel results generated. Once you have the test and the expected
results in your tree, use "svn add" to add them to your working copy, then use
the prepare-ChangeLog script to add ChangeLog entries (one in WebCore/ChangeLog
and another one in LayoutTest/ChangeLog). Edit the ChangeLogs and generate a
new patch.

More information about the webkit-reviews mailing list