[webkit-reviews] review denied: [Bug 11634] Windows port segfaults on startup : [Attachment 11553] patch v1

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Nov 17 12:16:21 PST 2006

Sam Weinig <sam.weinig at gmail.com> has denied Sam Weinig
<sam.weinig at gmail.com>'s request for review:
Bug 11634: Windows port segfaults on startup

Attachment 11553: patch v1

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
Despite what I said on IRC, I actually see 3 issues. 

- FrameLoaderClientWin.h needs a newline at the end.
- As long as we are making new files, we might as well follow the guidelines as
closely as possible.  So, in FrameLoaderClientWin.h please indent all of the
class declaration.
- Use '0' instead of 'NULL'.

More information about the webkit-reviews mailing list