[webkit-reviews] review requested: [Bug 10122] Background composite property should apply to background color, not just images : [Attachment 11545] Proposed patch

[bugzilla-request-daemon at macosforge.org]

Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 10122: Background composite property should apply to background color, not
just images
http://bugs.webkit.org/show_bug.cgi?id=10122

Attachment 11545: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=11545&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Makes -webkit-background-composite apply to background-color.
Adds compositeOperation() function to GraphicsContext.
Fixes functions in GraphicsContext that never drew when alpha() was 0,
this optimization only works when the compositeOperation is SourceOver.

* manual-tests/background-composite-color.html: Added.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect): check the compositeOperation
(WebCore::GraphicsContext::drawEllipse): ditto
(WebCore::GraphicsContext::drawConvexPolygon): ditto
(WebCore::GraphicsContext::fillRect): ditto
* platform/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::compositeOperation): Added.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):