[webkit-reviews] review denied: [Bug 11617] Compile and work on Qt/KDE platforms : [Attachment 11538] patch to fix Qt/KDE code

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Nov 16 09:11:42 PST 2006

Sam Weinig <sam.weinig at gmail.com> has denied Sam Weinig
<sam.weinig at gmail.com>'s request for review:
Bug 11617: Compile and work on Qt/KDE platforms

Attachment 11538: patch to fix Qt/KDE code

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
r- for a few missing things.

- Add the URL for this bug to the Changelog.
- #include "config.h" to ContextMenuClientQt.cpp.
- In ContextMenuClientQt.h, please but the opening curly-brace for the
namespace and the class on the same line as the declaration. Same goes for the
namespace in ContextMenuQt.cpp.
- No need for the braces around one line if statement in void
ContextMenu::appendItem(ContextMenuItem item)

- These last two are really nitpicking, but, in EditorClientQt.cpp, please
separate the #include "EditCommand.h" from the first 2 #includes as is our
style.	And, at the end of ContextMenuClientQt.cpp you have 2 newlines when
only one called for.

More information about the webkit-reviews mailing list