[webkit-reviews] review denied: [Bug 11598] NativePopUp: inner block is too big, causing focus ring to draw around clipped text : [Attachment 11525] Fix, creates style first.

[bugzilla-request-daemon at macosforge.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 11598: NativePopUp: inner block is too big, causing focus ring to draw
around clipped text
http://bugs.webkit.org/show_bug.cgi?id=11598

Attachment 11525: Fix, creates style first.
http://bugs.webkit.org/attachment.cgi?id=11525&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
The point of using a more lightweight clipping system for buttons and menulists
was to avoid creating RenderLayers for these controls.

In the case of single-line textfields this was unavoidable because we want to
be able to auto-scroll to reveal all the contents, but there's no reason to pay
this kind of penalty for menu lists or buttons.

Buttons use the same lightweight clip model that menulists do and so have the
same bugs.

Fixing this is very easy and involves subclassing nodeAtPoint to solve the hit
testing issues and making a tweak to the outline code to avoid descending into
children for blocks with the lightweight clipping model.