[webkit-reviews] review requested: [Bug 11596] KCanvasFilters rework : [Attachment 11520] Initial patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Nov 14 12:09:53 PST 2006


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 11596: KCanvasFilters rework
http://bugs.webkit.org/show_bug.cgi?id=11596

Attachment 11520: Initial patch
http://bugs.webkit.org/attachment.cgi?id=11520&action=edit

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Large patch including ChangeLogs.
The commiter must move the Wk* files from kcanvas/device/quartz/filters to
platform/graphics/svg/filters/cg (svn move!) this can't be included in the
patch, it would add/remove these files and loose history.

Finally the duplicated SVGFilter* enums are gone, and shared between
platform/graphics/svg/filters
and ksvg2/svg. All build system changes for Qt & Mac are included.

Have fun reviewing! :-)



More information about the webkit-reviews mailing list