[webkit-reviews] review denied: [Bug 11501] REGRESSION: \u no longer escapes metacharacters in RegExps : [Attachment 11477] Patch to fix 11501 et al.

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Nov 13 11:12:08 PST 2006


Sam Weinig <sam.weinig at gmail.com> has denied Sam Weinig
<sam.weinig at gmail.com>'s request for review:
Bug 11501: REGRESSION: \u no longer escapes metacharacters in RegExps
http://bugs.webkit.org/show_bug.cgi?id=11501

Attachment 11477: Patch to fix 11501 et al.
http://bugs.webkit.org/attachment.cgi?id=11477&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
r- for a few more issues.

No spaces before *'s

+    _regex = pcre_compile(reinterpret_cast<const uint16_t
*>(cleanedPattern.data()), options, &errorMessage, &errorOffset, NULL);


Add a comment for:

+  while (pos != -1 + 2) {

Please make the new functions static. And add the URL for this bug to the
changelogs.



More information about the webkit-reviews mailing list