[webkit-reviews] review denied: [Bug 11468] Group graphics related
files in platform/graphics : [Attachment 11472] Updated patch
including ChangeLogs
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Fri Nov 10 16:45:02 PST 2006
Adam Roben <aroben at apple.com> has denied Adam Roben <aroben at apple.com>'s
request for review:
Bug 11468: Group graphics related files in platform/graphics
http://bugs.webkit.org/show_bug.cgi?id=11468
Attachment 11472: Updated patch including ChangeLogs
http://bugs.webkit.org/attachment.cgi?id=11472&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+ B27535690B053814002CE64F /* FloatPoint.h in Headers */ = {isa =
PBXBuildFile; fileRef = B275353B0B053814002CE64F /* FloatPoint.h */; };
- BC73E3930978CED700EDFF8A /* FloatPoint.h in Headers */ = {isa =
PBXBuildFile; fileRef = BC73E3910978CED700EDFF8A /* FloatPoint.h */; settings =
{ATTRIBUTES = (Private, ); }; };
On a number of files you're losing the ATTRIBUTES flag. Take a look at
WebKitTools/Scripts/do-file-rename for how to rename files correctly. Perhaps
you can even use that script here?
It's really great that this move is being done!
More information about the webkit-reviews
mailing list