[webkit-reviews] review denied: [Bug 11555] StringImpl can corrupt the static empty string : [Attachment 11442] patch to String.cpp

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has denied Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 11555: StringImpl can corrupt the static empty string
http://bugs.webkit.org/show_bug.cgi?id=11555

Attachment 11442: patch to String.cpp
http://bugs.webkit.org/attachment.cgi?id=11442&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This looks like a design problem to me. According to a comment above the class
declaration, Strings are supposed to be shared - so, the fact that append()
implicitly copies (unlike insert(), replace() and truncate()) is formally a
bug, and the constructors that initialize m_impl to StringImpl::empty() are
incorrect...