[webkit-reviews] review denied: [Bug 11414] [s60]China Variant Crashes : [Attachment 11438] modified as suggested

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Nov 9 08:43:18 PST 2006

Zalan Bujtas <zbujtas at gmail.com> has denied Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 11414: [s60]China Variant Crashes

Attachment 11438: modified as suggested

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
1, ptr.Length() + tmpBuf.Length() should be passed to checkRealloc instead of
2, outBuf->Des().Copy( aPtr ) should be used instead of
as the buffer that aPtr points to is destroyed right after checkRealloc returns
(delete outBuf;)
3, checkRealloc should not leave, it should return null in case of oom.

More information about the webkit-reviews mailing list