[webkit-reviews] review denied: [Bug 11414] [s60]China Variant Crashes : [Attachment 11429] check for more reallocation condition

[bugzilla-request-daemon at macosforge.org]

Zalan Bujtas <zbujtas at gmail.com> has denied Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 11414: [s60]China Variant Crashes
http://bugs.webkit.org/show_bug.cgi?id=11414

Attachment 11429: check for more reallocation condition
http://bugs.webkit.org/attachment.cgi?id=11429&action=edit

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
checkRealloc should take two parameters, the current buffer and the length you
want to expand to and return the new buffer.
so instead of
TBool checkRealloc( HBufC8*  aBuf, TPtr8& aPtr, TInt aLen )
you should have something like
HBufC8* checkRealloc( TPtrC8& , TInt  ) 

then you dont have to do tricks like this
//
HBufC8* temp = aBuf->ReAlloc( maxlen + (len == maxlen ? 1 : aLen) );