[webkit-reviews] review requested: [Bug 9673] Add support for window.atob() and window.btoa() : [Attachment 11425] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Nov 8 09:20:56 PST 2006

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 9673: Add support for window.atob() and window.btoa()

Attachment 11425: proposed fix

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> Though, you should probably use the version of strncasecmp in StringExtras.h
> you can.

  Done (had to add the header to wtf, however - hope this is OK). Also made
this change in DeprecatedString.cpp.

> Please use "unsigned" instead of "unsigned int" in a bunch of places.

  Do we have such a rule? I don't see one in the guidelines, and I don't like
this style myself.

> Put spaces around infix operators in bunch of places as well.

  OK, but please note that I intentionally broke this rule in these places - I
think adding spaces there has a negative impact on redability. But done.

> Also, since this is based on the KDE impl, if there is a bug number or a
> that implemented this it would be nice to have a link to it or at least note
> who the author of the   patch was.

  Base64 implementation comes from kdecore and is completely unrelated to
khtml. Its authorship is already reflected in the copyright header.

  The kjs_window part of this implementation is trivial (but note the
getOwnPropertySlot question I asked in comment 2). I haven't researched its

More information about the webkit-reviews mailing list