[webkit-reviews] review denied: [Bug 9673] Add support for window.atob() and window.btoa() : [Attachment 11405] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Nov 8 07:11:42 PST 2006

Sam Weinig <sam.weinig at gmail.com> has denied Sam Weinig
<sam.weinig at gmail.com>'s request for review:
Bug 9673: Add support for window.atob() and window.btoa()

Attachment 11405: proposed fix

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
Setting r- due to a couple of issues I see.  

In Base64.cpp:

The * should be next to the type

+inline int strncasecmp(const char *first, const char *second, size_t

Though, you should probably use the version of strncasecmp in StringExtras.h if
you can.

Please use "unsigned" instead of "unsigned int" in a bunch of places.

Put spaces around infix operators in bunch of places as well.

Also, since this is based on the KDE impl, if there is a bug number or a patch
that implemented this it would be nice to have a link to it or at least note
who the author of the	patch was.

More information about the webkit-reviews mailing list