[webkit-reviews] review denied: [Bug 11501] REGRESSION: \u no longer escapes metacharacters in RegExps : [Attachment 11409] Patch to fix 11501 et al.

[bugzilla-request-daemon at macosforge.org]

Sam Weinig <sam.weinig at gmail.com> has denied Sam Weinig
<sam.weinig at gmail.com>'s request for review:
Bug 11501: REGRESSION: \u no longer escapes metacharacters in RegExps
http://bugs.webkit.org/show_bug.cgi?id=11501

Attachment 11409: Patch to fix 11501 et al.
http://bugs.webkit.org/attachment.cgi?id=11409&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
Marking r- as a few style issues remain.  

Please put spaces around infix operators.
 
+    next3 = (pos + 3 < length) ? code[pos+3].uc : -1;

the spaces inside the parenthesis are wrong even though they match the
surrounding style.

+	 if ( !lastWasEscape ) {

The * should be next to the type.

+    _regex = pcre_compile(reinterpret_cast<const uint16_t
*>(cleanedPattern.data()), options, &errorMessage, &errorOffset, NULL);

Also, please regenerate the ChangeLog as the names of the new functions have
changed.