[webkit-reviews] review requested: [Bug 9673] Add support for window.atob() and window.btoa() : [Attachment 11405] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Nov 6 12:32:58 PST 2006

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 9673: Add support for window.atob() and window.btoa()

Attachment 11405: proposed fix

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This implementation is based on the one from KDE, but has been tweaked for
better Firefox compatibility.

One thing I couldn't understand in khtml (and thus didn't copy) was a special
case for AToB/BToA in Window::getOwnPropertySlot:

    switch(entry->value) {
    case Frames:
// ...
    case Blur:
    case AToB:
    case BToA:
      getSlotFromEntry<WindowFunc, Window>(entry, this, slot);


WebCore has similar (but not identical) code for Blur etc. here, so maybe we
actually need it, too.

More information about the webkit-reviews mailing list